piair
0 Followers · 0 Following
  • Joined on 2024-01-01
Repositories
7
 Projects Packages Public Activity Starred Repositories
piair commented on pull request piair/MyINPulse#9 2025-04-23 10:33:01 +02:00
front_foundation

same comment, it should be gloabal

piair commented on pull request piair/MyINPulse#9 2025-04-23 10:33:01 +02:00
front_foundation

this should be in a specific css file.

piair commented on pull request piair/MyINPulse#9 2025-04-23 10:33:01 +02:00
front_foundation

Same, don't use axios

piair commented on pull request piair/MyINPulse#9 2025-04-23 10:33:01 +02:00
front_foundation

be careful with axiosInstance, but i may be fine

piair commented on pull request piair/MyINPulse#9 2025-04-23 10:33:01 +02:00
front_foundation

axios again

piair commented on pull request piair/MyINPulse#9 2025-04-23 10:33:01 +02:00
front_foundation

And the path is not right

piair commented on pull request piair/MyINPulse#9 2025-04-23 10:33:01 +02:00
front_foundation

same

piair commented on pull request piair/MyINPulse#9 2025-04-23 10:33:01 +02:00
front_foundation

I think CSS should be in a separated folder, but not a big issue.

piair commented on pull request piair/MyINPulse#9 2025-04-23 10:33:01 +02:00
front_foundation

it would be better to use variables for colors, but not a big issue either.

piair commented on pull request piair/MyINPulse#9 2025-04-23 10:33:01 +02:00
front_foundation

Can we find a better name ?

piair commented on pull request piair/MyINPulse#9 2025-04-23 10:33:01 +02:00
front_foundation

This should not be true

piair commented on pull request piair/MyINPulse#9 2025-04-23 10:33:01 +02:00
front_foundation

weird to use axiosInstance.

piair commented on pull request piair/MyINPulse#9 2025-04-23 10:33:01 +02:00
front_foundation

A supprimer

piair commented on pull request piair/MyINPulse#9 2025-04-23 10:33:01 +02:00
front_foundation

For now, it would be better to hide this altogether, I don't think we will have time to implement it.

piair commented on pull request piair/MyINPulse#9 2025-04-23 10:33:01 +02:00
front_foundation

The h2 from this file is the same as the h3 from the next (AgendaComponent). It would be better to have a single css file for this part.

piair commented on pull request piair/MyINPulse#9 2025-04-23 10:33:01 +02:00
front_foundation

same, button should look the same in the project, so the css shouldn't be scoped here

piair commented on pull request piair/MyINPulse#9 2025-04-23 10:33:01 +02:00
front_foundation

We must keep the same order for template and script everywhere.

piair commented on pull request piair/MyINPulse#9 2025-04-23 10:33:01 +02:00
front_foundation

same comment as before, most of the style here is not for this part only, so it should not be here

piair commented on pull request piair/MyINPulse#9 2025-04-23 10:33:01 +02:00
front_foundation

should this commented part really stay

piair commented on pull request piair/MyINPulse#9 2025-04-23 10:33:01 +02:00
front_foundation

This should not be shown to the user