front_foundation #9
Loading…
x
Reference in New Issue
Block a user
No description provided.
Delete Branch "front_foundation"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Avancement actuel du front en attente d'appointements et de génération de rapport, il faut aussi ajouter un end-point qui donne la liste des users qui n'ont pas une affectation claire...
remove contact.ts and dont make Dockerfile executable
@ -0,0 +1,63 @@
{
A supprimer
@ -0,0 +1,2 @@
#!/usr/bin/bash
a supprimer
@ -1,47 +1,12 @@
<script setup lang="ts">
import { RouterView } from "vue-router";
import { /*RouterLink,*/ RouterView } from "vue-router";
I don't like the comments in the middle of the line, it would be better to delete this part.
@ -15,2 +7,2 @@
/>
</div>
<Header />
<ErrorWrapper />
same, I don't think it's really important to keep comments
@ -0,0 +1,108 @@
<template>
We must keep the same order for template and script everywhere.
@ -0,0 +23,4 @@
/>
</div>
<div class="form-group">
For now, it would be better to hide this altogether, I don't think we will have time to implement it.
@ -0,0 +53,4 @@
</script>
<style scoped>
h2 {
The h2 from this file is the same as the h3 from the next (AgendaComponent). It would be better to have a single css file for this part.
@ -0,0 +92,4 @@
border-radius: 5px;
border: 1px solid #ccc;
}
same, button should look the same in the project, so the css shouldn't be scoped here
@ -0,0 +35,4 @@
</script>
<style scoped>
h3 {
same comment as before, most of the style here is not for this part only, so it should not be here
@ -0,0 +1,206 @@
<script lang="ts" setup>
The order changed here
@ -0,0 +31,4 @@
}
}
});
/*
should this commented part really stay
@ -0,0 +68,4 @@
<button @click="store.signup">Signup-Entrepreneur</button>
<button @click="store.refreshUserToken">Refresh Token</button>
</div>
This should not be shown to the user
@ -0,0 +76,4 @@
<p><strong>Refresh Token:</strong></p>
<pre>{{ store.user.refreshToken }}</pre>
</div>
same, it should be hidden
@ -0,0 +116,4 @@
width: 100%;
max-width: 600px;
}
global style once again
@ -17,3 +42,1 @@
required: true,
},
},
const IS_MOCK_MODE = true;
It would be better to use an ENV variable
@ -20,0 +88,4 @@
const responseData: Entrepreneur[] = useMock
? await mockFetchEntrepreneurs(/*projectId*/)
: (
await axios.get(
We should not use axios.get EVER, it does not send the authentication token.
@ -20,0 +115,4 @@
course: string;
sneeStatus: boolean;
};
I don't love the fact that the mock tests are in the code here, it should be better to have a server. It's not a big probleme though
@ -20,0 +150,4 @@
const contactAll = () => {
const allEmails = entrepreneurEmails.value.join(", ");
navigator.clipboard.writeText(allEmails).then(() => {
alert("Tous les emails copiés dans le presse-papiers !");
I personally hate that, can't we use an error mesage in green ?
ok
@ -22,0 +233,4 @@
line-height: 1.6;
}
button {
generic style once again
@ -0,0 +116,4 @@
const responseData = useMock
? await mockFetch(projectId, title, date)
: (await axios.get<{ txt: string }[]>(
`http://localhost:5000/shared/projects/lcsection/${projectId}/${title}/${date}`
Same, don't use axios
@ -0,0 +142,4 @@
const responseData = useMock
? await mockFetch(projectId, title, date)
: (
await axiosInstance.get<{ txt: string }[]>(
be careful with axiosInstance, but i may be fine
@ -0,0 +199,4 @@
const saveEdit = async (index: number) => {
try {
const id = index + 1; // À adapter selon l'ID réel des données
await axios.put(`http://localhost:5000/data/${id}`, {
axios again
And the path is not right
@ -0,0 +218,4 @@
} else {
try {
const id = index + 1;
await axios.put(`http://localhost:5000/data/${id}`, {
same
@ -0,0 +1,253 @@
<template>
Doesn't this header overlap with the main app canvas ?
@ -0,0 +28,4 @@
<script setup lang="ts">
import { ref, onMounted, onBeforeUnmount } from "vue";
import axios from "axios";
I won't talk again about axios
@ -0,0 +91,4 @@
const bootstrapCss = document.createElement("link");
bootstrapCss.rel = "stylesheet";
bootstrapCss.href =
"https://cdn.jsdelivr.net/npm/bootstrap@5.3.3/dist/css/bootstrap.min.css";
Why is bootstrap imported here ?
@ -0,0 +1,156 @@
body {
I think CSS should be in a separated folder, but not a big issue.
@ -0,0 +10,4 @@
.cell {
flex: 1;
border: 1px solid #ddd;
it would be better to use variables for colors, but not a big issue either.
@ -28,4 +28,46 @@ keycloakService.CallInit(() => {
}
});
// this shit made by me so i can run the canva vue app
We can't let this kind of comments
@ -31,0 +32,4 @@
//createApp(App).use(router).mount('#app');
// TODO: fix the comment
/*
remove this if it's commented.
@ -14,0 +36,4 @@
},
{
path: "/JorCproject",
Can we find a better name ?
ok
@ -55,3 +55,3 @@
try {
await keycloakService.CallLogout(
import.meta.env.VITE_APP_URL + "/test"
import.meta.env.VITE_APP_URL + "/" //redirect to login page instead of test...
remove comment
go to login instead ?
@ -0,0 +1,160 @@
<template>
<Header />
<error-wrapper></error-wrapper>
<div id="container">
it's a bit weird to have content here, if this file replaces main.vue, fine bud don"t put content on it
@ -0,0 +45,4 @@
//const URI = `http://localhost:${PORT}`;
//const projects = ref<{ name: string; link: string; members: string[] }[]>([]);
remove this comment
@ -0,0 +87,4 @@
onMounted(fetchProjects);
*/
what is that for ?
@ -0,0 +113,4 @@
</script>
<style scoped>
#container {
same comment for CSS
@ -0,0 +37,4 @@
import { ref, onMounted /*, defineProps*/ } from "vue";
import { axiosInstance } from "@/services/api.ts";
const IS_MOCK_MODE = true;
This should not be true
Le fetching n'est pas encore prêt pour passer à la base de données
@ -0,0 +81,4 @@
return;
}
const response = await axiosInstance.get(
weird to use axiosInstance.
@ -0,0 +108,4 @@
</script>
<style scoped>
@import url("https://fonts.googleapis.com/css2?family=Inter:wght@400;500;600&display=swap");
this should be in a specific css file.
@ -0,0 +119,4 @@
border-radius: 10px;
box-shadow: 0 4px 6px rgba(0, 0, 0, 0.1);
}
same comment, it should be gloabal
@ -0,0 +33,4 @@
<div v-if="choix === 'joindre'" class="message-indispo">
<h2>Joindre un projet</h2>
<p>⚠️ Cette fonctionnalité n'est pas encore disponible.</p>
remove this caracter
@ -0,0 +53,4 @@
alert("Veuillez entrer un nom de projet.");
return;
}
alert(`Projet "${nomProjet.value}" créé avec succès !`);
Just do it!
@ -19,3 +19,3 @@
position: absolute;
left: 70%;
//background-color: blue;
/*background-color: blue;*/
why ?
a
@ -0,0 +30,4 @@
}
defineProps<{
projectRDV: rendezVous[];
où est-ce que les RDV sont récupérés ?
@ -0,0 +196,4 @@
};
/*
const saveEdit = async (index: number) => {
Ce saveEdit utile étant donnée celle définie en dessous ?
@ -0,0 +145,4 @@
};
/*
const copyToClipboard = (email: string) => {
Cette fonction est-elle utilisée quelque part ?
Cf commentaires
Checkout
From your project repository, check out a new branch and test the changes.