piair/MyINPulse
2
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases Wiki Activity

front_foundation #9

Closed
mohamed_maoulainine wants to merge 181 commits from front_foundation into main
pull from: front_foundation
merge into: piair:main
Conversation 6 Commits 181 Files Changed 93 +79 -80
2 changed files with 79 additions and 80 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 6226c9f632 - Show all commits

12
front/MyINPulse-front/src/components/ProjectComponent.vue
View File

@ -9,7 +9,7 @@
Contact
</button>
<div class="dropdown-menu" v-if="isDropdownOpen">
<div v-if="isDropdownOpen" class="dropdown-menu">
<button @click.stop="contactAll">Contacter tous</button>
<button
v-for="(email, index) in entrepreneurEmails"
@ -34,7 +34,6 @@
</div>
</template>
<script setup lang="ts">
import { defineProps, ref, onMounted, onBeforeUnmount } from "vue";
import { useRouter } from "vue-router";
@ -87,7 +86,7 @@ const fetchEntrepreneurs = async (
) => {
try {
const responseData: Entrepreneur[] = useMock
? await mockFetchEntrepreneurs(projectId)
? await mockFetchEntrepreneurs(/*projectId*/)
: (
await axios.get(
adnane marked this conversation as resolved Outdated
piair commented 2025-04-23 10:10:29 +02:00
Outdated
Review
Copy Link

We should not use axios.get EVER, it does not send the authentication token.

We should not use axios.get EVER, it does not send the authentication token.
`http://localhost:5000/shared/projects/entrepreneurs/${projectId}`
@ -98,7 +97,10 @@ const fetchEntrepreneurs = async (
(item: Entrepreneur) => item.primaryMail
);
} catch (error) {
console.error("Erreur lors de la récupération des entrepreneurs :", error);
console.error(
"Erreur lors de la récupération des entrepreneurs :",
error
);
}
};
@ -114,7 +116,7 @@ type Entrepreneur = {
sneeStatus: boolean;
};
adnane marked this conversation as resolved Outdated
piair commented 2025-04-23 10:11:36 +02:00
Outdated
Review
Copy Link

I don't love the fact that the mock tests are in the code here, it should be better to have a server. It's not a big probleme though

I don't love the fact that the mock tests are in the code here, it should be better to have a server. It's not a big probleme though
const mockFetchEntrepreneurs = async (projectId: number) => {
const mockFetchEntrepreneurs = async (/*projectId: number*/) => {
return new Promise<Entrepreneur[]>((resolve) => {
setTimeout(() => {
resolve([

5
front/MyINPulse-front/src/components/canvas/HeaderCanvas.vue
View File

@ -3,7 +3,7 @@
<img src="../icons/logo inpulse.png" alt="INPulse Logo" class="logo" />
<div class="header-actions">
<div class="dropdown-wrapper" ref="dropdownRef">
<div ref="dropdownRef" class="dropdown-wrapper">
<button class="contact-button" @click.stop="toggleDropdown">
Contact
</button>
@ -26,7 +26,6 @@
</header>
</template>
<script setup lang="ts">
import { ref, onMounted, onBeforeUnmount } from "vue";
import axios from "axios";
adnane marked this conversation as resolved Outdated
piair commented 2025-04-23 10:19:52 +02:00
Outdated
Review
Copy Link

I won't talk again about axios

I won't talk again about axios
@ -171,11 +170,9 @@ onMounted(() => {
document.addEventListener("click", handleClickOutside);
});
onBeforeUnmount(() => {
document.removeEventListener("click", handleClickOutside);
});
</script>
<style scoped>